> On Nov 20, 2023, at 9:37 AM, Christian Brauner <brauner@xxxxxxxxxx> wrote: > > On Sun, 19 Nov 2023 18:56:17 -0500, Chuck Lever wrote: >> The new directory offset helpers don't conform with the convention >> of getdents() returning no more entries once a directory file >> descriptor has reached the current end-of-directory. >> >> To address this, copy the logic from dcache_readdir() to mark the >> open directory file descriptor once EOD has been reached. Seeking >> resets the mark. >> >> [...] > > Should fix the regression report I also received earlier today. You mean this one? https://bugzilla.kernel.org/show_bug.cgi?id=218147 It feels like it is similar if not the same. > Thanks for the > reviews with LPC and MS I couldn't really do any meaningful review. > > --- > > Applied to the vfs.fixes branch of the vfs/vfs.git tree. > Patches in the vfs.fixes branch should appear in linux-next soon. > > Please report any outstanding bugs that were missed during review in a > new review to the original patch series allowing us to drop it. > > It's encouraged to provide Acked-bys and Reviewed-bys even though the > patch has now been applied. If possible patch trailers will be updated. > > Note that commit hashes shown below are subject to change due to rebase, > trailer updates or similar. If in doubt, please check the listed branch. > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git > branch: vfs.fixes > > [1/1] libfs: getdents() should return 0 after reaching EOD > https://git.kernel.org/vfs/vfs/c/796432efab1e -- Chuck Lever
