> > That will cancel the batching effect on the swap slot free, making the > common case for swapping faults take longer to complete, righ? > If I recall correctly, the uncharge is the expensive part of the swap > slot free operation. > I just want to figure out what we are trading off against. This is not > one side wins all situations. > Hi Chris, thanks for your feedback. I have the same concerns, maybe we should just move the zswap_invalidate() out of batches, as Yosry mentioned above.