On Tue, Nov 14, 2023 at 04:21:26AM -0800, Mina Almasry wrote: > Actually because you put the 'strtuct page for devmem' in > skb->bv_frag, the net stack will grab the 'struct page' for devmem > using skb_frag_page() then call things like page_address(), kmap, > get_page, put_page, etc, etc, etc. Yikes, please no. If net has its own struct page look alike it has to stay entirely inside net. A non-mm owned struct page should not be passed into mm calls. It is just way too hacky to be seriously considered :( > > I would expect net stack, page pool, driver still see the 'struct page', > > only memory provider see the specific struct for itself, for the above, > > devmem memory provider sees the 'struct page_pool_iov'. > > > > The reason I still expect driver to see the 'struct page' is that driver > > will still need to support normal memory besides devmem. I wouldn't say this approach is unreasonable, but it does have to be done carefully to isolate the mm. Keeping the struct page in the API is going to make this very hard. Jason
