Re: [PATCH] staging: zsmalloc: fix uninit'ed variable warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Seth,

On 06/14/2012 06:03 AM, Seth Jennings wrote:

> This patch fixes an uninitialized variable warning in
> alloc_zspage().  It also fixes the secondary issue of
> prev_page leaving scope on each loop iteration.  The only
> reason this ever worked was because prev_page was occupying
> the same space on the stack on each iteration.
> 
> Signed-off-by: Seth Jennings <sjenning@xxxxxxxxxxxxxxxxxx>


Nice catch!

Acked-by: Minchan Kim <minchan@xxxxxxxxxx>

Nitpick:
I can't see the warning.
My gcc version is gcc (Ubuntu/Linaro 4.6.3-1ubuntu5) 4.6.3.

Please, Cced linux-mm, too.
Some guys in mm might have a interest in zsmalloc. :)

-- 
Kind regards,
Minchan Kim

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]