Hi Anish, On Thu, Nov 9, 2023 at 1:08 AM Anish Moorthy <amoorthy@xxxxxxxxxx> wrote: > > Applying [1] and [2] reveals that this also breaks non-x86 builds- the > MEM_REGION_GPA/SLOT definitions are guarded behind an #ifdef > __x86_64__, while the usages introduced here aren't. > > Should > > On Sun, Nov 5, 2023 at 8:35 AM Paolo Bonzini <pbonzini@xxxxxxxxxx> wrote: > > > > + test_invalid_memory_region_flags(); > > be #ifdef'd, perhaps? I'm not quite sure what the intent is. > > Side note: I wasn't able to get [2] to apply by copy-pasting the diff > and trying "git apply", and that was after checking out the relevant > commit. Eventually I just did it manually. If anyone can successfully > apply it, please let me know what you did so I can see what I was > doing wrong :) For me I applied the whole series as follows: Checkout kvm-x86-next-2023.11.01 (45b890f7689e) from https://github.com/kvm-x86/linux.git . Then use b4: b4 am -o - 20231105163040.14904-1-pbonzini@xxxxxxxxxx | git am -3 Cheers, /fuad > > [1] https://lore.kernel.org/kvm/20231108233723.3380042-1-amoorthy@xxxxxxxxxx/ > [2] https://lore.kernel.org/kvm/affca7a8-116e-4b0f-9edf-6cdc05ba65ca@xxxxxxxxxx/
