mm not MM, style not sytle. On Wed, 8 Nov 2023, Omkar Wagle wrote: > Remove most of the code style warnings > > Signed-off-by: Omkar Wagle<ov.wagle@xxxxxxxxx> > --- > mm/shmem.c | 51 +++++++++++++++++++++++++++++++++------------------ > 1 file changed, 33 insertions(+), 18 deletions(-) Thanks for trying, but I'm sorry: very little of this is an improvement. Almost all of it is just adding a blank line in between declaration and code in some small block (including at least one from Linus himself). checkpatch does a good job of encouraging tidy patches, but it makes no claim to being right; and that particular nag annoys me more often than any other (though I often grudgingly give in to it, just for a quiet life - Cc'ing Matthew because I suspect he resents it even more than I do). And look at those fsparams: Al and others have gone to the trouble of lining them up nicely, but you've decided to undo their work. I believe it's explained somewhere (but admit that a quick look in Documentation didn't show me where), that checkpatch is something to run to tidy up your patches, or new source files (or perhaps even staging); but please don't send its advice on well-established source files. Hugh
