On Wed, Nov 08, 2023 at 01:09:10AM -0800, Ankur Arora wrote: > > Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> writes: > > > On Tue, Nov 07, 2023 at 01:56:52PM -0800, Ankur Arora wrote: > >> This reverts commit 0a70045ed8516dfcff4b5728557e1ef3fd017c53. > >> > > > > None of these reverts say "why" the revert is needed, or why you even > > want to do this at all. Reverting a compilation error feels like you > > are going to be adding a compilation error to the build, which is > > generally considered a bad thing :( > > Yeah, one of the many issues with this string of reverts. > > I was concerned about repeating the same thing over and over enough > that I just put my explanation at the bottom of the cover-letter and > nowhere else. cover letters are not in the changelog when patches are committed :) thanks, greg k-h
