On Mon, Aug 07, 2023 at 07:01:16PM +0900, Hyeongtak Ji wrote: > shrink_lruvec() currently ignores previously reclaimed pages in > scan_control->nr_reclaimed. This can lead shrink_lruvec() to reclaiming > more pages than expected. > > This patch fixes shrink_lruvec() to take into account the previously > reclaimed pages. Do you run into real world issues from this? The code has been like this for at least a decade. It's an intentional choice to ensure fairness across all visited cgroups. sc->nr_to_reclaim is 32 pages or less - it's only to guard against extreme overreclaim. But we want to make sure we reclaim a bit from all cgroups, rather than always hit the first one and then bail.
