On Mon, Nov 06, 2023 at 06:41:37AM -0800, SeongJae Park wrote: > Hi Dan, > > On Mon, 6 Nov 2023 17:07:40 +0300 Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: > > > The "err" variable is not initialized if damon_target_has_pid(ctx) is > > false and sys_target->regions->nr is zero. > > Thank you for fixing this. I actually noticed this issue from Coverity Weekly > Scan of -next tree (CID 1570878), and was about to send very same fix, but you > were faster :) > > > > > Fixes: 0bcd216c4741 ("mm/damon/sysfs: update monitoring target regions for online input commit") > > Cc stable? > The fixes tag is from last week so I assumed it wasn't in stable yet. Also to be honest, I wasn't totally positive this bug could occur in real life. regards, dan carpenter