Re: [linux-next:master 14482/15964] sound/soc/amd/acp/acp-legacy-common.c:392:19: error: implicit declaration of function 'acpi_find_child_device'; did you mean 'acpi_match_device'?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 10/31/23 20:39, kernel test robot wrote:
tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   9c2d379d63450ae464eeab45462e0cb573cd97d0
commit: 3a94c8ad0aae2b14a55059869871ea2d199af489 [14482/15964] ASoC: amd: acp: add code for scanning acp pdm controller
config: x86_64-buildonly-randconfig-001-20231031 (https://download.01.org/0day-ci/archive/20231031/202310312340.o6CthxSp-lkp@xxxxxxxxx/config)
compiler: gcc-11 (Debian 11.3.0-12) 11.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231031/202310312340.o6CthxSp-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202310312340.o6CthxSp-lkp@xxxxxxxxx/

Note: the linux-next/master HEAD 9c2d379d63450ae464eeab45462e0cb573cd97d0 builds fine.
       It may have been fixed somewhere.

All errors (new ones prefixed by >>):

    sound/soc/amd/acp/acp-legacy-common.c: In function 'check_acp_pdm':
sound/soc/amd/acp/acp-legacy-common.c:392:19: error: implicit declaration of function 'acpi_find_child_device'; did you mean 'acpi_match_device'? [-Werror=implicit-function-declaration]
      392 |         pdm_dev = acpi_find_child_device(ACPI_COMPANION(&pci->dev), pdm_addr, 0);
          |                   ^~~~~~~~~~~~~~~~~~~~~~
          |                   acpi_match_device
    sound/soc/amd/acp/acp-legacy-common.c:392:17: warning: assignment to 'struct acpi_device *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
      392 |         pdm_dev = acpi_find_child_device(ACPI_COMPANION(&pci->dev), pdm_addr, 0);
          |                 ^
    cc1: some warnings being treated as errors

Fix for this issue is already merged in ASoC tree.

https://lore.kernel.org/all/20231027152403.386257-1-arnd@xxxxxxxxxx



vim +392 sound/soc/amd/acp/acp-legacy-common.c

    354	
    355	int check_acp_pdm(struct pci_dev *pci, struct acp_chip_info *chip)
    356	{
    357		struct acpi_device *pdm_dev;
    358		const union acpi_object *obj;
    359		u32 pdm_addr, val;
    360	
    361		val = readl(chip->base + ACP_PIN_CONFIG);
    362		switch (val) {
    363		case ACP_CONFIG_4:
    364		case ACP_CONFIG_5:
    365		case ACP_CONFIG_6:
    366		case ACP_CONFIG_7:
    367		case ACP_CONFIG_8:
    368		case ACP_CONFIG_10:
    369		case ACP_CONFIG_11:
    370		case ACP_CONFIG_12:
    371		case ACP_CONFIG_13:
    372		case ACP_CONFIG_14:
    373			break;
    374		default:
    375			return -EINVAL;
    376		}
    377	
    378		switch (chip->acp_rev) {
    379		case ACP3X_DEV:
    380			pdm_addr = ACP_RENOIR_PDM_ADDR;
    381			break;
    382		case ACP6X_DEV:
    383			pdm_addr = ACP_REMBRANDT_PDM_ADDR;
    384			break;
    385		case ACP63_DEV:
    386			pdm_addr = ACP63_PDM_ADDR;
    387			break;
    388		default:
    389			return -EINVAL;
    390		}
    391	
  > 392		pdm_dev = acpi_find_child_device(ACPI_COMPANION(&pci->dev), pdm_addr, 0);
    393		if (pdm_dev) {
    394			if (!acpi_dev_get_property(pdm_dev, "acp-audio-device-type",
    395						   ACPI_TYPE_INTEGER, &obj) &&
    396						   obj->integer.value == pdm_addr)
    397				return 0;
    398		}
    399		return -ENODEV;
    400	}
    401	EXPORT_SYMBOL_NS_GPL(check_acp_pdm, SND_SOC_ACP_COMMON);
    402	





[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux