On Mon, Jun 11, 2012 at 10:40 AM, Christoph Lameter <cl@xxxxxxxxx> wrote: > On Mon, 11 Jun 2012, KOSAKI Motohiro wrote: > >> On 6/11/2012 10:02 AM, Christoph Lameter wrote: >> > On Mon, 11 Jun 2012, kosaki.motohiro@xxxxxxxxx wrote: >> > >> >> From: KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx> >> >> >> >> commit 2244b95a7b (zoned vm counters: basic ZVC (zoned vm counter) >> >> implementation) broke protection column. It is a part of "pages" >> >> attribute. but not it is showed after vmstats column. >> >> >> >> This patch restores the right position. >> > >> > Well this reorders the output. vmstats are also counts of pages. I am not >> > sure what the difference is. >> >> No. In this case, "pages" mean zone attribute. In the other hand, vmevent >> is a statistics. > > The vmevent countes are something different from the zone counters. Event > counters are indeed statistics only but the numbers here were intended > to be are actual counts of pages. Well some of them like the numa_XXX are > stats you are right. Those could be moved off the ZVCs and become event > counters. > >> > You are not worried about breaking something that may scan the zoneinfo >> > output with this change? Its been this way for 6 years and its likely that >> > tools expect the current layout. >> >> I don't worry about this. Because of, /proc/zoneinfo is cray machine unfrinedly >> format and afaik no application uses it. > > Cray? What does that have to do with it. sorry. s/cray/crazy/ > >> btw, I believe we should aim /sys/devices/system/node/<node-num>/zones new directory >> and export zone infos as machine readable format. > > Yes that would be a good thing. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>