On Mon, 2012-06-11 at 10:31 -0400, Konrad Rzeszutek Wilk wrote: > > I'm not sure of the correct kernel style but I like the fact > > that assert_spin_locked both documents the lock requirement and tests > > it at runtime. > > The kernel style is to do " > 3) Separate your changes. > > Separate _logical changes_ into a single patch file. > " > > So it is fine, but it should be in its own patch. It is one logical change: I've moved a block of code that has to be locked in the swap mutex into it's own function, adding the spinlock assertion isn't new code, nor it relates to any new code. It's there to assert that what happened before still happens now. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>