On Mon 11-06-12 10:38:10, Michal Hocko wrote: > On Sat 09-06-12 14:29:56, Aneesh Kumar K.V wrote: > > From: "Aneesh Kumar K.V" <aneesh.kumar@xxxxxxxxxxxxxxxxxx> > > > > This patchset add the charge and uncharge routines for hugetlb cgroup. > > This will be used in later patches when we allocate/free HugeTLB > > pages. > > Please describe the locking rules. > > > Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@xxxxxxxxxxxxxxxxxx> > > --- > > mm/hugetlb_cgroup.c | 87 +++++++++++++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 87 insertions(+) > > > > diff --git a/mm/hugetlb_cgroup.c b/mm/hugetlb_cgroup.c > > index 20a32c5..48efd5a 100644 > > --- a/mm/hugetlb_cgroup.c > > +++ b/mm/hugetlb_cgroup.c > > @@ -105,6 +105,93 @@ static int hugetlb_cgroup_pre_destroy(struct cgroup *cgroup) > > return -EBUSY; > > } > > > > +int hugetlb_cgroup_charge_page(int idx, unsigned long nr_pages, > > + struct hugetlb_cgroup **ptr) > > Missing doc. And now that I am looking at the patch which uses this function then I realized that the name shouldn't mention page as we do not use any as an argument. It is more in lines with hugetlb_cgroup_charge_cgroup -- Michal Hocko SUSE Labs SUSE LINUX s.r.o. Lihovarska 1060/12 190 00 Praha 9 Czech Republic -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>