On Tue, 24 Oct 2023, kernel test robot wrote: > Hi Hugh, > > kernel test robot noticed the following build warnings: > > > > url: https://github.com/intel-lab-lkp/linux/commits/UPDATE-20231024-144517/Hugh-Dickins/hugetlbfs-drop-shared-NUMA-mempolicy-pretence/20231003-173301 > base: the 10th patch of https://lore.kernel.org/r/74e34633-6060-f5e3-aee-7040d43f2e93%40google.com > patch link: https://lore.kernel.org/r/00dc4f56-e623-7c85-29ea-4211e93063f6%40google.com > patch subject: [PATCH] mempolicy: alloc_pages_mpol() for NUMA policy without vma: fix > config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20231024/202310241551.uY40myKo-lkp@xxxxxxxxx/config) > compiler: m68k-linux-gcc (GCC) 13.2.0 > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231024/202310241551.uY40myKo-lkp@xxxxxxxxx/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot <lkp@xxxxxxxxx> > | Closes: https://lore.kernel.org/oe-kbuild-all/202310241551.uY40myKo-lkp@xxxxxxxxx/ > > All warnings (new ones prefixed by >>): > > In file included from mm/zswap.c:41: > mm/internal.h: In function 'shrinker_debugfs_name_alloc': > mm/internal.h:1232:9: warning: function 'shrinker_debugfs_name_alloc' might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format] > 1232 | shrinker->name = kvasprintf_const(GFP_KERNEL, fmt, ap); > | ^~~~~~~~ > mm/zswap.c: In function 'zswap_writeback_entry': > mm/zswap.c:1322:16: error: implicit declaration of function 'get_task_policy'; did you mean 'get_vma_policy'? [-Werror=implicit-function-declaration] > 1322 | mpol = get_task_policy(current); > | ^~~~~~~~~~~~~~~ > | get_vma_policy > >> mm/zswap.c:1322:14: warning: assignment to 'struct mempolicy *' from 'int' makes pointer from integer without a cast [-Wint-conversion] > 1322 | mpol = get_task_policy(current); > | ^ > cc1: some warnings being treated as errors Gaah, thanks for that, I never built it without CONFIG_NUMA=y: v2 patch with a get_task_policy() without CONFIG_NUMA coming up, built this time. Hugh