On 2023/10/24 2:16, Andrew Morton wrote: > On Mon, 23 Oct 2023 10:51:25 +0800 Liu Shixin <liushixin2@xxxxxxxxxx> wrote: > >> Leave __alloc_object() just do the actual allocation and __link_object() >> do the full initialisation. > Changelog doesn't describe why we're making this change? > . In patch (“mm: kmemleak: split __create_object into two functions”), the initialisation of object has been splited in two places. Catalin said it feels a bit weird and error prone. So leave __alloc_object() just do the actual allocation and __link_object() do the full initialisation. thanks, >