On Mon, Oct 9, 2023 at 11:00 AM Alexander Potapenko <glider@xxxxxxxxxx> wrote: > > > +static void depot_keep_next_pool(void **prealloc) > > { > > /* > > - * If the next pool is already initialized or the maximum number of > > + * If the next pool is already saved or the maximum number of > > * pools is reached, do not use the preallocated memory. > > */ > > if (!next_pool_required) > It's not mentioned at the top of the file that next_pool_required is > protected by pool_lock, but it is, correct? > Can you please update the comment to reflect that? I'll add a clarifying comment above this access to the previous patch. I don't think it's worth to describe all locking intricacies of the existing code in other places, as atomic accesses are removed altogether later in the series anyway. Thanks!