Hi, On 10/21/2023 5:17 AM, Alexei Starovoitov wrote: > On Fri, Oct 20, 2023 at 11:03 AM Dennis Zhou <dennis@xxxxxxxxxx> wrote: >> On Fri, Oct 20, 2023 at 10:58:37AM -0700, Alexei Starovoitov wrote: >>> On Fri, Oct 20, 2023 at 10:48 AM Dennis Zhou <dennis@xxxxxxxxxx> wrote: >>>> On Fri, Oct 20, 2023 at 09:31:57PM +0800, Hou Tao wrote: >>>>> From: Hou Tao <houtao1@xxxxxxxxxx> >>>>> SNIP >>>>> + * >>>>> + * Returns the size of the @ptr allocation. This is undefined for statically >>>> ^ >>>> >>>> Nit: Alexei, when you pull this, can you make it a double space here? >>>> Just keeps percpu's file consistent. >>> Argh. Already applied. >>> That's a very weird style you have in a few places. >>> $ grep '\. [A-z]' mm/*.c|wc -l >>> 1118 >>> $ grep '\. [A-z]' mm/*.c|wc -l >>> 2451 >>> >>> Single space is used more often in mm/* and in the rest of the kernel. >>> >>> $ grep '\. [A-z]' mm/percpu.c|wc -l >>> 10 >>> >>> percpu.c isn't consistent either. >>> >>> I can force push if you really insist. >> Eh, if it's trouble I can fix it in the future. I know single space is >> more common, but percpu was written with double so I'm trying my best to >> keep the file consistent. > Ok. Fair enough. > Force pushed with double space. Thanks for the fixes. When I copied the sentence from the email, there was indeed double spaces in it, but I simply ignored and "fixed" it, and I also didn't double check the used style in mm/percpu.c. Will be more carefully next time.
