Re: [PATCH] mm/buddy: cleanup on should_fail_alloc_page

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 9 Jun 2012, Gavin Shan wrote:

> In the core function __alloc_pages_nodemask() of buddy allocator, it's
> possible for the memory allocation to fail. That's probablly caused
> by error injection with expection. In that case, it depends on the
> check of error injection covered by function should_fail(). Currently,
> function should_fail() has "bool" for its return value, so it's reasonable
> to change the return value of function should_fail_alloc_page() into
> "bool" as well.
> 

I think we can remove the first three sentences of this.

> The patch does cleanup on function should_fail_alloc_page() to "bool".
> 
> Signed-off-by: Gavin Shan <shangw@xxxxxxxxxxxxxxxxxx>

Acked-by: David Rientjes <rientjes@xxxxxxxxxx>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]