On Thu, 5 Oct 2023 10:30:36 -0700 Yosry Ahmed <yosryahmed@xxxxxxxxxx> wrote: > On Thu, Oct 5, 2023 at 9:30 AM Michal Koutný <mkoutny@xxxxxxxx> wrote: > > > > On Thu, Oct 05, 2023 at 02:31:03AM -0700, Yosry Ahmed <yosryahmed@xxxxxxxxxx> wrote: > > > I am not really sure what you mean here. > > > > My "vision" is to treat WORKINGSET_ entries as events. > > That would mean implementing per-node tracking for vm_event_item > > (costlier?). > > That would mean node_stat_item and vm_event_item being effectively > > equal, so they could be merged in one. > > That would be situation to come up with new classification based on use > > cases (e.g. precision/timeliness requirements, state vs change > > semantics). > > > > (Do not take this as blocker of the patch 1/2, I rather used the > > opportunity to discuss a greater possible cleanup.) > > Yeah ideally we can clean this up separately. I would be careful about > userspace exposure though. It seems like CONFIG_VM_EVENT_COUNTERS is > used to control tracking events and displaying them in vmstat, so > moving items between node_stat_item and vm_event_item (or merging > them) won't be easy. I like the word "separately". This series has been in mm-unstable for nearly a month, so I'll move it into mm-stable as-is,
