2012/6/9 Christoph Lameter <cl@xxxxxxxxx>: > On Sat, 9 Jun 2012, Joonsoo Kim wrote: > >> -static struct kmem_cache *get_slab(size_t size, gfp_t flags) >> +static __always_inline struct kmem_cache *get_slab(size_t size, gfp_t flags) > > I thought that the compiler felt totally free to inline static functions > at will? This may be a matter of compiler optimization settings. I can > understand the use of always_inline in a header file but why in a .c file? Yes, but the compiler with -O2 doesn't inline get_slab() which declared just 'static'. I think that inlining get_slab() have a performance benefit, so add '__always_inline' to declare of get_slab(). Other functions like slab_alloc, slab_free also use 'always_inline' in .c file (slub.c) -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>