Konrad Rzeszutek Wilk <konrad@xxxxxxxxxx> writes: > On Sat, Jun 09, 2012 at 02:29:47PM +0530, Aneesh Kumar K.V wrote: >> From: "Aneesh Kumar K.V" <aneesh.kumar@xxxxxxxxxxxxxxxxxx> >> >> The current use of VM_FAULT_* codes with ERR_PTR requires us to ensure >> VM_FAULT_* values will not exceed MAX_ERRNO value. Decouple the >> VM_FAULT_* values from MAX_ERRNO. > > I see you using the -ENOMEM|-ENOSPC, but I don't see any reference in the > code to MAX_ERRNO? Can you provide a comment explaining in a tad little > bit about the interaction of MAX_ERRNO and VM_FAULT? That comes from this #define IS_ERR_VALUE(x) unlikely((x) >= (unsigned long)-MAX_ERRNO) -aneesh -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>