On Fri, 2012-06-08 at 18:04 -0400, Konrad Rzeszutek Wilk wrote: > On Fri, Jun 08, 2012 at 09:15:09PM +0200, Sasha Levin wrote: > > Most of these patches are minor cleanups to the mm/frontswap.c code, the big > > chunk of new code can be attributed to the new tracing support. > > > > > > Changes in v2: > > - Rebase to current version > > - Address Konrad's comments > > There was one comment that I am not sure if it was emailed and that > was about adding the "lockdep_assert_held(&swap_lock);". > > You added that in two patches, while the git commit only talks about > "move that code" . Please remove it out of the "move the code" patches > and add it as a seperate git commit with an explanation of why it > is added. argh, I forgot to comment on that as well. Sorry. > Otherwise (well, the compile issue that was spotted) the patches > look great. Could you repost them with those two fixes please? Will do. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>