Re: [PATCH v3] memblock: don't run loop in memblock_add_range() twice

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 2023/10/12 17:24, Mike Rapoport wrote:
On Thu, Oct 05, 2023 at 11:20:19PM +0800, Yajun Deng wrote:
On 2023/10/5 13:19, Mike Rapoport wrote:

I don't see this micro-optimization is worth the churn and potential bugs.
NAK.
There are many handouts that tell people it needs to run twice in
memblock_add_range().

I think it's time to change this. I'm trying to tell people that running
twice is unnecessary.
It might be unnecessary, but it's still simpler than the solutions you
proposed. And, again, removing the second loop is not worth the churn and
potential bugs.


Okay, I got it. Thanks.





[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux