On Fri, Oct 6, 2023 at 2:08 PM Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote: > > On Tue, 3 Oct 2023 09:21:22 -0700 Suren Baghdasaryan <surenb@xxxxxxxxxx> wrote: > > > > @@ -633,7 +641,7 @@ int vma_expand(struct vma_iterator *vmi, struct vm_area_struct *vma, > > > > > > remove_next = true; > > > vma_start_write(next); > > > - ret = dup_anon_vma(vma, next); > > > + ret = dup_anon_vma(vma, next, &anon_dup); > > > if (ret) > > > return ret; > > > > Shouldn't the above be changed to a "goto nomem" instead of "return ret" ? > > It looks OK to me as-is - dup_anon_vma() leaves anon_dup==NULL > when it returns error. Yes, I realised that after sending the question and didn't want to create more noise than I already did... All seems good.
