On Sun, Oct 01, 2023 at 11:26:18PM -0700, Christoph Hellwig wrote:
> > + * If the invalidate lock is not held, the folio was in cache and
> > + * uptodate and now it is not. Strange but possible since we
>
> Please don't spill block comments ôver the 80 charater limit, that makes
> them impossible to read nicely.
>
Yup this was because checkpatch ok'd it, I've aliased the strict 80 char param
so it won't happen again.
Fix patch enclosed
----8<----
>From 3abb740abb67505b6f83d7602f7b4a8dcd29977f Mon Sep 17 00:00:00 2001
From: Lorenzo Stoakes <lstoakes@xxxxxxxxx>
Date: Mon, 2 Oct 2023 07:37:24 +0100
Subject: [PATCH] mm/filemap: clarify filemap_fault() comments for not uptodate case
Correct identation as per Christopher's feedback.
Signed-off-by: Lorenzo Stoakes <lstoakes@xxxxxxxxx>
---
mm/filemap.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/mm/filemap.c b/mm/filemap.c
index 959694a2ade7..951709089f38 100644
--- a/mm/filemap.c
+++ b/mm/filemap.c
@@ -3314,10 +3314,10 @@ vm_fault_t filemap_fault(struct vm_fault *vmf)
*/
if (unlikely(!folio_test_uptodate(folio))) {
/*
- * If the invalidate lock is not held, the folio was in cache and
- * uptodate and now it is not. Strange but possible since we
- * didn't hold the page lock all the time. Let's drop everything,
- * get the invalidate lock and try again.
+ * If the invalidate lock is not held, the folio was in cache
+ * and uptodate and now it is not. Strange but possible since we
+ * didn't hold the page lock all the time. Let's drop
+ * everything, get the invalidate lock and try again.
*/
if (!mapping_locked) {
folio_unlock(folio);
--
2.42.0
