On 27.09.23 02:39, Stefan Roesch wrote:
Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> writes:
On Tue, 26 Sep 2023 09:13:31 -0700 Stefan Roesch <shr@xxxxxxxxxxxx> wrote:
Thinking about it, what are the cons of just enabling this always and not
exposing new toggles? Alternatively, we could make this a compile-time option.
In general, LGTM, just curious if we really have to make this configurable.
The only downside I can see is that it might take a longer time for some
pages to be de-duplicated (a new candidate page is added, but its
duplicate is skipped in this round). So it will take longer to
de-duplicate this page.
I tested with more than one workload, but it might be useful to get some
data with additional workloads. I was thinking of enabling it after one or
two releases.
We could keep the tunable and make it default "on"?
Sounds good to me
+1
Reviewed-by: David Hildenbrand <david@xxxxxxxxxx>
--
Cheers,
David / dhildenb
