tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 940fcc189c51032dd0282cbee4497542c982ac59 commit: 9dee0f7a734a116a6b8d205207672b85aef764ba [4198/6975] bcachefs: Cleanup redundant snapshot nodes config: x86_64-randconfig-122-20230922 (https://download.01.org/0day-ci/archive/20230922/202309220808.fotJNegS-lkp@xxxxxxxxx/config) compiler: gcc-11 (Debian 11.3.0-12) 11.3.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230922/202309220808.fotJNegS-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202309220808.fotJNegS-lkp@xxxxxxxxx/ sparse warnings: (new ones prefixed by >>) >> fs/bcachefs/snapshot.c:989:41: sparse: sparse: cast to restricted __le32 >> fs/bcachefs/snapshot.c:989:39: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __le32 @@ got unsigned int [usertype] @@ fs/bcachefs/snapshot.c:989:39: sparse: expected restricted __le32 fs/bcachefs/snapshot.c:989:39: sparse: got unsigned int [usertype] fs/bcachefs/snapshot.c:942:5: sparse: sparse: symbol 'bch2_snapshot_node_delete' was not declared. Should it be static? vim +989 fs/bcachefs/snapshot.c 941 942 int bch2_snapshot_node_delete(struct btree_trans *trans, u32 id) 943 { 944 struct bch_fs *c = trans->c; 945 struct btree_iter iter, p_iter = (struct btree_iter) { NULL }; 946 struct btree_iter c_iter = (struct btree_iter) { NULL }; 947 struct btree_iter tree_iter = (struct btree_iter) { NULL }; 948 struct bkey_s_c_snapshot s; 949 u32 parent_id, child_id; 950 unsigned i; 951 int ret = 0; 952 953 s = bch2_bkey_get_iter_typed(trans, &iter, BTREE_ID_snapshots, POS(0, id), 954 BTREE_ITER_INTENT, snapshot); 955 ret = bkey_err(s); 956 bch2_fs_inconsistent_on(bch2_err_matches(ret, ENOENT), c, 957 "missing snapshot %u", id); 958 959 if (ret) 960 goto err; 961 962 BUG_ON(s.v->children[1]); 963 964 parent_id = le32_to_cpu(s.v->parent); 965 child_id = le32_to_cpu(s.v->children[0]); 966 967 if (parent_id) { 968 struct bkey_i_snapshot *parent; 969 970 parent = bch2_bkey_get_mut_typed(trans, &p_iter, 971 BTREE_ID_snapshots, POS(0, parent_id), 972 0, snapshot); 973 ret = PTR_ERR_OR_ZERO(parent); 974 bch2_fs_inconsistent_on(bch2_err_matches(ret, ENOENT), c, 975 "missing snapshot %u", parent_id); 976 if (unlikely(ret)) 977 goto err; 978 979 /* find entry in parent->children for node being deleted */ 980 for (i = 0; i < 2; i++) 981 if (le32_to_cpu(parent->v.children[i]) == id) 982 break; 983 984 if (bch2_fs_inconsistent_on(i == 2, c, 985 "snapshot %u missing child pointer to %u", 986 parent_id, id)) 987 goto err; 988 > 989 parent->v.children[i] = le32_to_cpu(child_id); 990 991 normalize_snapshot_child_pointers(&parent->v); 992 } 993 994 if (child_id) { 995 struct bkey_i_snapshot *child; 996 997 child = bch2_bkey_get_mut_typed(trans, &c_iter, 998 BTREE_ID_snapshots, POS(0, child_id), 999 0, snapshot); 1000 ret = PTR_ERR_OR_ZERO(child); 1001 bch2_fs_inconsistent_on(bch2_err_matches(ret, ENOENT), c, 1002 "missing snapshot %u", child_id); 1003 if (unlikely(ret)) 1004 goto err; 1005 1006 child->v.parent = cpu_to_le32(parent_id); 1007 1008 if (!child->v.parent) { 1009 child->v.skip[0] = 0; 1010 child->v.skip[1] = 0; 1011 child->v.skip[2] = 0; 1012 } 1013 } 1014 1015 if (!parent_id) { 1016 /* 1017 * We're deleting the root of a snapshot tree: update the 1018 * snapshot_tree entry to point to the new root, or delete it if 1019 * this is the last snapshot ID in this tree: 1020 */ 1021 struct bkey_i_snapshot_tree *s_t; 1022 1023 BUG_ON(s.v->children[1]); 1024 1025 s_t = bch2_bkey_get_mut_typed(trans, &tree_iter, 1026 BTREE_ID_snapshot_trees, POS(0, le32_to_cpu(s.v->tree)), 1027 0, snapshot_tree); 1028 ret = PTR_ERR_OR_ZERO(s_t); 1029 if (ret) 1030 goto err; 1031 1032 if (s.v->children[0]) { 1033 s_t->v.root_snapshot = s.v->children[0]; 1034 } else { 1035 s_t->k.type = KEY_TYPE_deleted; 1036 set_bkey_val_u64s(&s_t->k, 0); 1037 } 1038 } 1039 1040 ret = bch2_btree_delete_at(trans, &iter, 0); 1041 err: 1042 bch2_trans_iter_exit(trans, &tree_iter); 1043 bch2_trans_iter_exit(trans, &p_iter); 1044 bch2_trans_iter_exit(trans, &c_iter); 1045 bch2_trans_iter_exit(trans, &iter); 1046 return ret; 1047 } 1048 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
