On 06/04/2012 03:26 AM, Pekka Enberg wrote: > On Fri, 1 Jun 2012, Anton Vorontsov wrote: >>> That's pretty awful. Anton, Leonid, comments? >> [...] >>>> 5) __VMEVENT_ATTR_STATE_VALUE_WAS_LT should be removed from userland >>>> exporting files. >>>> When exporing kenrel internal, always silly gus used them and made unhappy. >>> >>> Agreed. Anton, care to cook up a patch to do that? >> >> KOSAKI-San, Pekka, >> >> Much thanks for your reviews! >> >> These three issues should be fixed by the following patches. One mm/ >> change is needed outside of vmevent... >> >> And I'm looking into other issues you pointed out... > > I applied patches 2, 4, and 5. The vmstat patch need ACKs from VM folks > to enter the tree. > > Pekka It's time to wrap it up. It seems some people include me have tried to improve vmevent But I hope let us convince why we need vmevent before further review/patch. Recently I tried reclaim-latency based notifier to consider backed device speed I mentioned elsewhere thread. The working model is that measure reclaim time and if it doesn't finish requirement time which is configurable by admin, notify it to user or kill some thread but I didn't published yet because it's not easy for admin to control and several issues. AFAIK, low memory notifier is started for replacing android lowmemory killer. At the same time, other folks want use it generally. As I look through android low memory killer, it's not too bad except some point. 1. It should not depend on shrink_slab. If we need, we can add some hook in vmscan.c directly instead of shrink_slab. 2. We can use out_of_memory instead of custom victim selection/killing function. If we need, we can change out_of_memory interface little bit for passing needed information to select victim. 3. calculation for available pages 1) and 2) would make android low memory killer very general and 3) can meet each folk's requirement, I believe. Anton, I expect you already investigated android low memory killer so maybe you know pros and cons of each solution. Could you convince us "why we need vmevent" and "why can't android LMK do it?" KOSAKI, AFAIRC, you are a person who hates android low memory killer. Why do you hate it? If it solve problems I mentioned, do you have a concern, still? If so, please, list up. Android low memory killer is proved solution for a long time, at least embedded area(So many android phone already have used it) so I think improving it makes sense to me rather than inventing new wheel. Frankly speaking, I don't know vmevent's other use cases except low memory notification and didn't see any agreement about that with other guys. I hope we get an agreement about vmevent before further enhance. Thanks, all. -- Kind regards, Minchan Kim -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>