Hello Vlastimil, On Wed, Sep 13, 2023 at 11:33:52AM +0200, Vlastimil Babka wrote: > On 9/12/23 16:50, Johannes Weiner wrote: > > From 429d13322819ab38b3ba2fad6d1495997819ccc2 Mon Sep 17 00:00:00 2001 > > From: Johannes Weiner <hannes@xxxxxxxxxxx> > > Date: Tue, 12 Sep 2023 10:16:10 -0400 > > Subject: [PATCH] mm: page_alloc: optimize free_unref_page_list() > > > > Move direct freeing of isolated pages to the lock-breaking block in > > the second loop. This saves an unnecessary migratetype reassessment. > > > > Minor comment and local variable scoping cleanups. > > Looks like batch_count and locked_zone could be moved to the loop scope as well. Hm they both maintain values over multiple iterations, so I don't think that's possible. Am I missing something? > > Suggested-by: Vlastimil Babka <vbabka@xxxxxxx> > > Signed-off-by: Johannes Weiner <hannes@xxxxxxxxxxx> > > Reviewed-by: Vlastimil Babka <vbabka@xxxxxxx> Thanks! I'll send this out properly with your tag.