Re: Common 04/22] [slab] Use page struct fields instead of casting

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 31 May 2012, David Rientjes wrote:

> On Wed, 23 May 2012, Christoph Lameter wrote:
>
> > Add fields to the page struct so that it is properly documented that
> > slab overlays the lru fields.
> >
> > This cleans up some casts in slab.
> >
>
> Sounds good, but...
>
> > Index: linux-2.6/include/linux/mm_types.h
> > ===================================================================
> > --- linux-2.6.orig/include/linux/mm_types.h	2012-05-22 09:05:49.716464025 -0500
> > +++ linux-2.6/include/linux/mm_types.h	2012-05-22 09:21:28.532444572 -0500
> > @@ -90,6 +90,10 @@ struct page {
> >  				atomic_t _count;		/* Usage count, see below. */
> >  			};
> >  		};
> > +		struct {		/* SLAB */
> > +			struct kmem_cache *slab_cache;
> > +			struct slab *slab_page;
> > +		};
> >  	};
> >
> >  	/* Third double word block */
>
> The lru fields are in the third double word block.

Right. This slipped somehow into an earlier double word block. Next
patchset fixes that.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]