On 09/06/23 17:31, Yuan Can wrote: > In vmemmap_remap_free(), a new head vmemmap page is allocated to avoid > breaking a contiguous block of struct page memory, however, the allocation > can always fail when the given node is movable node. Remove the > __GFP_THISNODE to help avoid fragmentation. > > Suggested-by: Mike Kravetz <mike.kravetz@xxxxxxxxxx> > Suggested-by: Muchun Song <songmuchun@xxxxxxxxxxxxx> > Signed-off-by: Yuan Can <yuancan@xxxxxxxxxx> > --- > mm/hugetlb_vmemmap.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Thanks, Reviewed-by: Mike Kravetz <mike.kravetz@xxxxxxxxxx> -- Mike Kravetz > > diff --git a/mm/hugetlb_vmemmap.c b/mm/hugetlb_vmemmap.c > index c2007ef5e9b0..27fc65b8e37e 100644 > --- a/mm/hugetlb_vmemmap.c > +++ b/mm/hugetlb_vmemmap.c > @@ -325,8 +325,7 @@ static int vmemmap_remap_free(unsigned long start, unsigned long end, > .vmemmap_pages = &vmemmap_pages, > }; > int nid = page_to_nid((struct page *)start); > - gfp_t gfp_mask = GFP_KERNEL | __GFP_THISNODE | __GFP_NORETRY | > - __GFP_NOWARN; > + gfp_t gfp_mask = GFP_KERNEL | __GFP_NORETRY | __GFP_NOWARN; > > /* > * Allocate a new head vmemmap page to avoid breaking a contiguous > -- > 2.17.1 >
