Re: [PATCH] mm: hugetlb_vmemmap: avoid allocation failure message in alloc_vmemmap_page_list()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




在 2023/9/6 15:25, Muchun Song 写道:

On Sep 6, 2023, at 15:22, Yuan Can <yuancan@xxxxxxxxxx> wrote:


在 2023/9/6 14:52, Muchun Song 写道:

On Sep 6, 2023, at 14:34, Yuan Can <yuancan@xxxxxxxxxx> wrote:

When vmemmap pages allocation failed, the hugetlb pages fail to free,
which is not an fatel error, so avoid the allocation failure report by
passing __GFP_NOWARN in gfp_mask.

You have misunderstand me and Mike. We mean the memory allocation
in vmemmap_remap_free() which also use __GFP_THISNODE, it has the
same issue as you fixed in another thread. But the failure of memory
allocation is not fetal. And it is better to remove __GFP_THISNODE
as well.

Thanks.

Ok, sorry about this, I will send another patch to remove __GFP_THISNODE in
vmemmap_remap_free, and I would like to know is it ok to add __GFP_NOWARN in
alloc_vmemmap_page_list()?
Do not do this. We need a warning here.

Thanks.
Ok, thanks for the reply.

--
Best regards,
Yuan Can





[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux