On 01/09/2023 05:03, Matthew Wilcox wrote: > On Thu, Aug 31, 2023 at 03:29:59PM +0100, Ryan Roberts wrote: >> On 25/08/2023 14:59, Matthew Wilcox (Oracle) wrote: >>> Most of its callees are not yet ready to accept a folio, but we know >>> all of the pages passed in are actually folios because they're linked >>> through ->lru. >>> @@ -2469,17 +2469,17 @@ void free_unref_page(struct page *page, unsigned int order) >>> void free_unref_page_list(struct list_head *list) >> >> Given the function has *page* in the title and this conversion to folios >> internally doesn't actually change any behaviour, I don't personally see a lot >> of value in doing this conversion. But if the aim is that everything eventually >> becomes a folio, then fair enough. > > It makes the next patch _way_ more obvious ;-) If you merge the two > patches together, almost every line changes. Yep, agreed now that I have the context of the whole series!