On Fri, Aug 25, 2023 at 01:04:31PM -0700, Nick Desaulniers wrote: > > I think the issue is that: > > > > # CONFIG_VFIO is not set > > CONFIG_KVM_VFIO=y > > > > And > > > > kvm-$(CONFIG_KVM_VFIO) += $(KVM)/vfio.o > > > > Which is a combination that doesn't make any sense. > > > > Looks like CONFIG_KVM_VFIO should probably be called CONFIG_KVM_ARCH_VFIO > > > > And then > > > > config KVM_VFIO > > bool > > depends on KVM_ARCH_VFIO > > depends on VFIO > > > > (or similar) > > > > So we don't even attempt to compile kvm/vfio.c if we don't have VFIO > > support turned on. > > Do we need to split the Kconfig? > > ``` > diff --git a/virt/kvm/Kconfig b/virt/kvm/Kconfig > index 484d0873061c..e5ebf89de855 100644 > --- a/virt/kvm/Kconfig > +++ b/virt/kvm/Kconfig > @@ -61,6 +61,7 @@ config HAVE_KVM_CPU_RELAX_INTERCEPT > > config KVM_VFIO > bool > + depends on VFIO .. I don't know these details about kconfig very well, I assume there is are reason most things are done with the HAVE_xx approach? Jason
