on 8/29/2023 11:05 PM, Mel Gorman wrote: > On Sat, Aug 26, 2023 at 11:36:15PM +0800, Kemeng Shi wrote: >> We have compact_blockskip_flush check in __reset_isolation_suitable, just >> remove repeat check before __reset_isolation_suitable in >> compact_blockskip_flush. >> >> Signed-off-by: Kemeng Shi <shikemeng@xxxxxxxxxxxxxxx> >> Reviewed-by: Baolin Wang <baolin.wang@xxxxxxxxxxxxxxxxx> > > The comment should move to __reset_isolation_suitable but otherwise > Thanks for the review, I will move comment in next version. > Acked-by: Mel Gorman <mgorman@xxxxxxxxxxxxxxxxxxx> > > As a complete aside, the reset_isolation_suitable and > __reset_isolation_suitable were badly named because locking is not > involved but it's meaningless churn to fix it. >
