Hi Eric! On 2023-08-29 18:48, Eric W. Biederman wrote: > > The kernel rules do allow removing the structure tag if we no one > is using it. If someone is using it then the bug is a regression. > > If you have the energy you can do a good faith search to see if there > is any likely hood that anyone is using it. At a quick look I don't > see anything including linux/elf.h. Add in a debian code search > (is there a github or gitlab code search?) and you can make a > pretty firm dent how widespread that is. Thanks for suggesting it. That gave me the energy. ;) It seems nobody is using it. At least not in Debian. $ # packages that contain 'include [<"]linux/elf\.h[">]' $ curl -s https://codesearch.debian.net/results/e5e7c74dfcdae609/packages.txt > include $ # packages that contain '\bstruct dynamic\b' $ curl -s https://codesearch.debian.net/results/b23577e099048c6a/packages.txt > struct $ cat struct include | sort | uniq -d chromium hurd linux qemu qt6-webengine qtwebengine-opensource-src $ # chromium: Seems to hold a copy of the UAPI header. No uses of the tag. $ # hurd: Same thing as chromium. $ # linux: :) $ # qemu: Same thing as chromium. $ # qt6-webengine: Same thing as all. $ # qtwebengine-opensource-src: Yet another copy. > > After a good faith search you can merge a patch to remove it, > and then if anyone reports a problem because you somehow missed > them you can revert the change. I've prepared a patch. When it finishes building, I'll send it. Cheers, Alex -- <http://www.alejandro-colomar.es/> GPG key fingerprint: A9348594CE31283A826FBDD8D57633D441E25BB5
Attachment:
OpenPGP_signature
Description: OpenPGP digital signature
