On Tue, Aug 29, 2023 at 03:19:29PM +0100, Matthew Wilcox wrote: > > > You'll be glad to know I've factored out a nice little helper for that. > > > > OK, what's it called? This is just copied from release_pages() at the moment. > > Happy to use your helper in the refactored common helper. > > I'll send out those patches today. No, wait, I sent them on Friday. https://lore.kernel.org/linux-mm/20230825135918.4164671-9-willy@xxxxxxxxxxxxx/ is the important one from your point of view. It's __page_cache_release() which is a little different from the current __page_cache_release()