On 08/28/23 15:15, Muchun Song wrote: > > > > On Aug 25, 2023, at 19:18, Usama Arif <usama.arif@xxxxxxxxxxxxx> wrote: > > > > If tail page prep and initialization is skipped, then the "start" > > page will not contain the correct nid. Use the nid from first > > vmemap page. > > > > Signed-off-by: Usama Arif <usama.arif@xxxxxxxxxxxxx> > > Make sense even if without your optimization. Because the nid is > used for allocation for "reuse" page, it really should be extracted > from "reuse" page instead of "start" page. > > Reviewed-by: Muchun Song <songmuchun@xxxxxxxxxxxxx> Agree that using reuse is better than start here. However, IIUC there is no way start and reuse could be on different nodes today. Reviewed-by: Mike Kravetz <mike.kravetz@xxxxxxxxxx> -- Mike Kravetz