Re: [PATCH v2] mm/vmscan: Use folio_migratetype() instead of get_pageblock_migratetype()

[David Hildenbrand <david@xxxxxxxxxx>]

On 25.08.23 09:57, Vern Hao wrote:
> From: Vern Hao <vernhao@xxxxxxxxxxx>
>
> In skip_cma(), we can use folio_migratetype() to replace get_pageblock_migratetype().
>
> Signed-off-by: Vern Hao <vernhao@xxxxxxxxxxx>
> ---
> v1 -> v2
> 	- remove "Fixs:xxx" as David Hildenbrand suggestion.
>
>   mm/vmscan.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index 2b5d61eeb039..850811bb5699 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -2271,7 +2271,7 @@ static bool skip_cma(struct folio *folio, struct scan_control *sc)
>   {
>   	return !current_is_kswapd() &&
>   			gfp_migratetype(sc->gfp_mask) != MIGRATE_MOVABLE &&
> -			get_pageblock_migratetype(&folio->page) == MIGRATE_CMA;
> +			folio_migratetype(folio) == MIGRATE_CMA;

Reviewed-by: David Hildenbrand <david@xxxxxxxxxx>

--
Cheers,

David / dhildenb