Re: [PATCH mm-unstable v1 1/4] mm/swap: stop using page->private on tail pages for THP_SWAP

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Yosry Ahmed <yosryahmed@xxxxxxxxxx>
Subject: Re: [PATCH mm-unstable v1 1/4] mm/swap: stop using page->private on tail pages for THP_SWAP
From: David Hildenbrand <david@xxxxxxxxxx>
Date: Tue, 22 Aug 2023 19:14:55 +0200
Cc: linux-kernel@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Matthew Wilcox <willy@xxxxxxxxxxxxx>, Peter Xu <peterx@xxxxxxxxxx>, Catalin Marinas <catalin.marinas@xxxxxxx>, Will Deacon <will@xxxxxxxxxx>, Hugh Dickins <hughd@xxxxxxxxxx>, Seth Jennings <sjenning@xxxxxxxxxx>, Dan Streetman <ddstreet@xxxxxxxx>, Vitaly Wool <vitaly.wool@xxxxxxxxxxxx>
In-reply-to: <CAJD7tkZNjwq6sWE5hCh6rYpSdD0quGFevXWq9eO_t3tHQBTNmA@mail.gmail.com>
Organization: Red Hat
References: <20230821160849.531668-1-david@redhat.com> <20230821160849.531668-2-david@redhat.com> <CAJD7tkZNjwq6sWE5hCh6rYpSdD0quGFevXWq9eO_t3tHQBTNmA@mail.gmail.com>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0


+static inline swp_entry_t page_swap_entry(struct page *page)
+{
+       struct folio *folio = page_folio(page);
+       swp_entry_t entry = folio_swap_entry(folio);
+
+       entry.val += page - &folio->page;


Would it be better to use folio_page_idx() here?


Sounds reasonable!

--
Cheers,

David / dhildenb

References:
- [PATCH mm-unstable v1 0/4] mm/swap: stop using page->private on tail pages for THP_SWAP + cleanups
  - From: David Hildenbrand
- [PATCH mm-unstable v1 1/4] mm/swap: stop using page->private on tail pages for THP_SWAP
  - From: David Hildenbrand
- Re: [PATCH mm-unstable v1 1/4] mm/swap: stop using page->private on tail pages for THP_SWAP
  - From: Yosry Ahmed

Prev by Date: Re: [PATCH v2 07/13] mm: Remove HUGETLB_PAGE_DTOR
Next by Date: Re: [PATCH v5 11/37] mm: Define VM_SHADOW_STACK for arm64 when we support GCS
Previous by thread: Re: [PATCH mm-unstable v1 1/4] mm/swap: stop using page->private on tail pages for THP_SWAP
Next by thread: Re: [PATCH mm-unstable v1 1/4] mm/swap: stop using page->private on tail pages for THP_SWAP
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]