Andrew Morton wrote: > On Wed, 30 May 2012 00:18:31 +0400 > Konstantin Khlebnikov <khlebnikov@xxxxxxxxxx> wrote: > >> Oleg Nesterov wrote: >>> On 05/22, Andrew Morton wrote: >>>> >>>> Also, I have a note here that Oleg was unhappy with the patch. Oleg >>>> happiness is important. Has he cheered up yet? >>> >>> Well, yes, I do not really like this patch ;) Because I think there is >>> a more simple/straightforward fix, see below. In my opinion it also >>> makes the original code simpler. >>> >>> But. Obviously this is subjective, I can't prove my patch is "better", >>> and I didn't try to test it. >>> >>> So I won't argue with Konstantin who dislikes my patch, although I >>> would like to know the reason. >> >> I don't remember why I dislike your patch. >> For now I can only say ACK ) > > We'll need a changelogged signed-off patch, please Oleg. And some evidence > that it was tested would be nice ;) I will reboot in few hours, finally after few days ... I am running this first patch. I will try to test the second/alternative patch more quickly. Sorry for the delay. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>