On 10/08/2023 19:31, Linus Torvalds wrote: > On Thu, 10 Aug 2023 at 10:35, Yu Zhao <yuzhao@xxxxxxxxxx> wrote: >> >> Adding the original author and reviewers... They might want (need) to >> take a look at this series. > > It looks fine to me. The important part is that the rmap removal has > to be done after the TLB flush, but before the page table lock is > released. Yes, we still abide by this rule for the !PageAnon(page) pages. > > That used to be a special thing for anonymous pages and thus needed > that special flag. But if it's done for *all* pages the need to flag > pages goes away. I think you misstyped - assuming you meant pagecache pages rather than anonymous pages? > > I see no issues with this, although obviously I might have missed something. Thanks for looking so quickly - really appreciate it. And sorry not to have included you initially. Thanks, Ryan > > Linus
