On Thu, Aug 10, 2023 at 11:09:20AM +0200, Rasmus Villemoes wrote: > On 10/08/2023 10.15, Petr Mladek wrote: ... > > + prolonging the list of #include lines in .c file. It will > > not help with maintainability which was one of the motivation > > in this patchset. > > We really have to stop pretending it's ok to rely on header a.h > automatically pulling in b.h, if a .c file actually uses something > declared in b.h. [Of course, the reality is more complicated; e.g. we > have many cases where one must include linux/foo.h, not asm/foo.h, but > the actual declarations are in the appropriate arch-specific file. > However, we should not rely on linux/bar.h pulling in linux/foo.h.] Btw, it's easy to enforce IIUC, i.e. by dropping #ifndef _FOO_H #define _FOO_H #endif mantra from the headers. -- With Best Regards, Andy Shevchenko
