On Mon, Aug 07, 2023 at 05:06:33PM +0200, Petr Mladek wrote: > On Sat 2023-08-05 20:50:27, Andy Shevchenko wrote: > > Sparse is not happy to see non-static variable without declaration: > > lib/vsprintf.c:61:6: warning: symbol 'no_hash_pointers' was not declared. Should it be static? > > > > Declare respective variable in the sprintf.h. With this, add a comment > > to discourage its use if no real need. > If we agreed to move sprintf() declarations into printk.h > then this might go to printk.h as well. Sure, but I disagree with printk.h approach (as I explained why in the reply to the suggestion). -- With Best Regards, Andy Shevchenko
