Re: [PATCH 6/7] mm/mmap.c: use helper macro K()

[David Hildenbrand <david@xxxxxxxxxx>]

On 04.08.23 03:25, Peng Zhang wrote:
> From: ZhangPeng <zhangpeng362@xxxxxxxxxx>
>
> Use helper macro K() to improve code readability. No functional
> modification involved.
>
> Signed-off-by: ZhangPeng <zhangpeng362@xxxxxxxxxx>
> ---
>   mm/mmap.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/mm/mmap.c b/mm/mmap.c
> index bc91d91261ab..35b6bc9c7c95 100644
> --- a/mm/mmap.c
> +++ b/mm/mmap.c
> @@ -3785,7 +3785,7 @@ static int init_user_reserve(void)
>   {
>   	unsigned long free_kbytes;
>   
> -	free_kbytes = global_zone_page_state(NR_FREE_PAGES) << (PAGE_SHIFT - 10);
> +	free_kbytes = K(global_zone_page_state(NR_FREE_PAGES));
>   
>   	sysctl_user_reserve_kbytes = min(free_kbytes / 32, 1UL << 17);
>   	return 0;
> @@ -3806,7 +3806,7 @@ static int init_admin_reserve(void)
>   {
>   	unsigned long free_kbytes;
>   
> -	free_kbytes = global_zone_page_state(NR_FREE_PAGES) << (PAGE_SHIFT - 10);
> +	free_kbytes = K(global_zone_page_state(NR_FREE_PAGES));
>   
>   	sysctl_admin_reserve_kbytes = min(free_kbytes / 32, 1UL << 13);
>   	return 0;
> @@ -3850,7 +3850,7 @@ static int reserve_mem_notifier(struct notifier_block *nb,
>   
>   		break;
>   	case MEM_OFFLINE:
> -		free_kbytes = global_zone_page_state(NR_FREE_PAGES) << (PAGE_SHIFT - 10);
> +		free_kbytes = K(global_zone_page_state(NR_FREE_PAGES));
>   
>   		if (sysctl_user_reserve_kbytes > free_kbytes) {
>   			init_user_reserve();

Reviewed-by: David Hildenbrand <david@xxxxxxxxxx>

--
Cheers,

David / dhildenb