On 8/7/23, Matthew Wilcox <willy@xxxxxxxxxxxxx> wrote: > On Mon, Aug 07, 2023 at 01:16:11AM +0200, Mateusz Guzik wrote: >> Otherwise the kernel ends up with multiple copies: >> $ nm vmlinux | grep dummy_vm_ops >> ffffffff81e4ea00 d dummy_vm_ops.2 >> ffffffff81e11760 d dummy_vm_ops.254 >> ffffffff81e406e0 d dummy_vm_ops.4 >> ffffffff81e3c780 d dummy_vm_ops.7 >> >> While here prefix it with vma_. > > It really shouldn't be prefixed with vma. Other than that, I love this > patch. > I think an unprefixed global is iffy, but I'm not going to insist on semi-cosmetics. The one thing I expected people to complain about is the location of the struct. The mm_init.c file was the least bad choice I found, but maybe something else is preferred? I'm just trying to avoid sending V3 for this patch after someone claims dummy ops should land elsewhere. ;) -- Mateusz Guzik <mjguzik gmail.com>
