Re: [PATCH v2 4/6] mm: lock vma explicitly before doing vm_flags_reset and vm_flags_reset_once

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Suren Baghdasaryan <surenb@xxxxxxxxxx>
Subject: Re: [PATCH v2 4/6] mm: lock vma explicitly before doing vm_flags_reset and vm_flags_reset_once
From: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
Date: Wed, 2 Aug 2023 11:53:48 -0700
Cc: akpm@xxxxxxxxxxxxxxxxxxxx, jannh@xxxxxxxxxx, willy@xxxxxxxxxxxxx, liam.howlett@xxxxxxxxxx, david@xxxxxxxxxx, peterx@xxxxxxxxxx, ldufour@xxxxxxxxxxxxx, vbabka@xxxxxxx, michel@xxxxxxxxxxxxxx, jglisse@xxxxxxxxxx, mhocko@xxxxxxxx, hannes@xxxxxxxxxxx, dave@xxxxxxxxxxxx, hughd@xxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, stable@xxxxxxxxxxxxxxx
In-reply-to: <CAJuCfpFYq4yyj0=nW0iktoH0dma-eFhw1ni7v9R-fCsYH7eQ3Q@mail.gmail.com>
References: <20230801220733.1987762-1-surenb@google.com> <20230801220733.1987762-5-surenb@google.com> <CAHk-=wix_+xyyAXf+02Pgt3xEpfKncjT8A6n1Oa+9uKH8bXnEA@mail.gmail.com> <CAJuCfpFYq4yyj0=nW0iktoH0dma-eFhw1ni7v9R-fCsYH7eQ3Q@mail.gmail.com>

On Wed, 2 Aug 2023 at 11:09, Suren Baghdasaryan <surenb@xxxxxxxxxx> wrote:
>
> Ok, IOW the vma would be already locked before mmap() is called...

Yup.

> Just to confirm, you are suggesting to remove vma_start_write() call
> from hfi1_file_mmap() and let vm_flags_reset() generate an assertion
> if it's ever called with an unlocked vma, correct?

Correct.

               Linus

Follow-Ups:
- Re: [PATCH v2 4/6] mm: lock vma explicitly before doing vm_flags_reset and vm_flags_reset_once
  - From: Suren Baghdasaryan

References:
- [PATCH v2 0/6] make vma locking more obvious
  - From: Suren Baghdasaryan
- [PATCH v2 4/6] mm: lock vma explicitly before doing vm_flags_reset and vm_flags_reset_once
  - From: Suren Baghdasaryan
- Re: [PATCH v2 4/6] mm: lock vma explicitly before doing vm_flags_reset and vm_flags_reset_once
  - From: Linus Torvalds
- Re: [PATCH v2 4/6] mm: lock vma explicitly before doing vm_flags_reset and vm_flags_reset_once
  - From: Suren Baghdasaryan

Prev by Date: Re: [PATCH v6 1/7] fs: pass the request_mask to generic_fillattr
Next by Date: Re: [PATCH v6 2/7] fs: add infrastructure for multigrain timestamps
Previous by thread: Re: [PATCH v2 4/6] mm: lock vma explicitly before doing vm_flags_reset and vm_flags_reset_once
Next by thread: Re: [PATCH v2 4/6] mm: lock vma explicitly before doing vm_flags_reset and vm_flags_reset_once
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]