Hello Arnd! On Wed, 2023-08-02 at 16:19 +0200, Arnd Bergmann wrote: > On Tue, Aug 1, 2023, at 21:21, John Paul Adrian Glaubitz wrote: > > > > I think ideally all the I/O port stuff in arch/sh/ could just be > > > removed after the conversion to asm-generic/io.h, but the > > > microdev_ioport_map() function oddity gets in the way of that, > > > unless someone wants to clean up that platform. As far as I > > > can tell, the ethernet, display, USB and PCI devices on it already > > > broke at some point (afbb9d8d5266b, 46bc85872040a), so it might > > > be easier to remove it entirely. > > > > I don't have this particular hardware, so I cannot comment on this. > > Sure, as I explained, I'm pretty sure that nobody has > tried to boot this hardware in a long time, so I did not > expect you to have one. > > I'll try to follow up with a patch to remove the platform > later on, based on the explations above. There is no need to remove any platforms now as we're working on converting arch/sh to device trees anyway and will eventually get rid of all the board- specific code during that step. > > > Having the series go into linux-next sounds appropriate like this, > > > the entire purpose of that is to find such bugs and Andrew can jus > > > fold the fixup into the broken patch. > > > > > > Let me know if you prefer the simple version with the extra > > > #defines or if we should just use the generic inb/outb implementation > > > immediately and drop microdev in a separate patch. > > > > Please go ahead with the simple version. > > Done, Thanks, Adrian -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer `. `' Physicist `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
