Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> writes: > On Tue, 22 May 2012 17:13:11 +0530 > "Aneesh Kumar K.V" <aneesh.kumar@xxxxxxxxxxxxxxxxxx> wrote: > >> Expose the failcnt details to userspace similar to memory and memsw. > > Why? > to help us find whether there was an allocation failure due to HugeTLB limit. > In general, it is best not to add any new userspace interfaces at all. > We will do so, if there are good reasons. But you've provided no reason > at all. > >> include/linux/hugetlb.h | 2 +- >> mm/memcontrol.c | 40 ++++++++++++++++++++++++++-------------- > > Documentation/cgroups/memory.txt needs updating also. You modify the > user insterface, you modify documentation - this should be automatic > for all of us. How about the below diff --git a/Documentation/cgroups/memory.txt b/Documentation/cgroups/memory.txt index 730e222a..3a47ec5 100644 --- a/Documentation/cgroups/memory.txt +++ b/Documentation/cgroups/memory.txt @@ -80,6 +80,7 @@ Brief summary of control files. memory.hugetlb.<hugepagesize>.max_usage_in_bytes # show max "hugepagesize" hugetlb usage recorded memory.hugetlb.<hugepagesize>.usage_in_bytes # show current res_counter usage for "hugepagesize" hugetlb # see 5.7 for details + memory.hugetlb.<hugepagesize>.failcnt # show the number of allocation failure due to HugeTLB limit 1. History -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>