On Mon, Jul 24, 2023 at 05:46:57PM +0200, Jann Horn wrote: > On Tue, Jul 11, 2023 at 10:20 PM Matthew Wilcox (Oracle) > <willy@xxxxxxxxxxxxx> wrote: > > Push the check down from __handle_mm_fault(). There's a mild upside to > > this patch in that we'll allocate the page tables while under the VMA > > lock rather than the mmap lock, reducing the hold time on the mmap lock, > > since the retry will find the page tables already populated. > > This commit, by moving the check from __handle_mm_fault() to > handle_pte_fault(), also makes the non-anonymous THP paths (including > the DAX huge fault handling) reachable for VMA-locked faults, right? > Is that intentional? Oof, this patch is all kinds of buggy. Will split this into several pieces. Thanks!